Skip to content

[skip changelog] use absolute URL in docs version selector #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

[skip changelog] use absolute URL in docs version selector #718

merged 1 commit into from
May 22, 2020

Conversation

masci
Copy link
Contributor

@masci masci commented May 22, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Bugfix in docs website

  • What is the current behavior?

When users select the docs version from the recently added selector control, the relative URL is used and browser is pointed to https://arduino.github.io/<version> instead of https://arduino.github.io/arduino-cli/<version>/ resulting in a 404

  • What is the new behavior?

Use the absolute url https://arduino.github.io/arduino-cli/ as a prefix for the destination URL

  • Does this PR introduce a breaking change?

No changes to the CLI

See how to contribute

@masci masci added the topic: documentation Related to documentation for the project label May 22, 2020
@masci masci requested a review from rsora May 22, 2020 08:04
rsora
rsora approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@masci masci merged commit b378a6a into master May 22, 2020
@masci masci deleted the massi/fix-js branch May 22, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @rsora